--- In Eddie Dawydiuk <> wrote:
>
> Robert,
>
> > I had to build a static version of eraseall myself, the mtd utilities are
> > open
> > source (yay!). They are available here:
> >
> > http://www.linux-mtd.infradead.org/source.html
>
> Thanks for pointing out where to download the source...
>
> FYI GIT repository: git://git.infradead.org/mtd-utils.git
>
> We simply commented out the code that checks if a block has been marked bad.
> Keep in mind the mtd drivers need to have this same logic commented out as
> the
> mtd kernel code does the same type of check.
>
> "flash_eraseall.c" 291L, 7412C written
> :mtd-utils$ diff -u orig.flash_eraseall.c flash_eraseall.c
> --- orig.flash_eraseall.c 2009-08-17 13:21:30.000000000 -0700
> +++ flash_eraseall.c 2009-08-17 13:21:51.000000000 -0700
> @@ -127,6 +127,7 @@
> for (erase.start = 0; erase.start < meminfo.size; erase.start +=
> meminfo.erasesize) {
> if (bbtest) {
> loff_t offset = erase.start;
> + /*
> int ret = ioctl(fd, MEMGETBADBLOCK, &offset);
> if (ret > 0) {
> if (!quiet)
> @@ -144,6 +145,7 @@
> return 1;
> }
> }
> + */
> }
>
> if (!quiet)
> :mtd-utils$
>
> As I've mentioned earlier on this list, if you have any questions please give
> us
> a call or an email. We're more than happy to help you out and I promise we
> won't
> bite :)
>
>
Eddie.
many thanks for posting the diff, I thought it was probably a simple mod like
that and I already had the original GPL source but this is not the kind of area
where suck and see is a valid option. I think you do provide the source along
with the vmlinux.bin on the ftp server so that should be easy to check.
I would respectfully point out however that posting a diff here is not GPL
compliance. You should make the full source available. Exactly the source that
builds the binary.
I'm sure it's an over sight and since you have asked to be notified of any
cases on non compliance ,,, it would be nice not to have to call transatlantic
or email and wait the weekend for a reply. Having a source tarball on the
server next to the binary would save you and "us" time and effort. As well as
fulfilling your license obligations.
This is exactly what GPL is about. You profit from the work of others and if
you make a mod, you contribute that back in.
Thanks again for your help. I hope this can undo the damage done by yaffs2.
There are reports on the aleph1 site about some chips becoming unusable after
this sort of erase.
Do you do anything else before mkfs on boards that you get back with this sort
of problem?
Best regards.
------------------------------------
Yahoo! Groups Links
<*> To visit your group on the web, go to:
http://groups.yahoo.com/group/ts-7000/
<*> Your email settings:
Individual Email | Traditional
<*> To change settings online go to:
http://groups.yahoo.com/group/ts-7000/join
(Yahoo! ID required)
<*> To change settings via email:
<*> To unsubscribe from this group, send an email to:
<*> Your use of Yahoo! Groups is subject to:
http://docs.yahoo.com/info/terms/
|