Re: [ts-7000] Re: Inverted polarity RTS/DTR on TS7260 kernel 2.6

[Petr Štetiar <>]

ToddV <> [2011-02-23 17:10:47]:

Hi Todd,

> Yes, the polarity of the RTS/CTS lines are incorrect as implemented in the
> kernel code for the ep93xx. These are set in the ep93xx_uart_set_mctrl()
> function in arch/arm/mach-ep93xx/core.c
> 
> Here is the patch that I apply when building my kernels:
> 
> diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c
> index ffdf87b..5718cca 100644
> --- a/arch/arm/mach-ep93xx/core.c
> +++ b/arch/arm/mach-ep93xx/core.c
> @@ -251,9 +251,9 @@ static void ep93xx_uart_set_mctrl(struct amba_device *dev,
>         unsigned int mcr;
>  
>         mcr = 0;
> -       if (!(mctrl & TIOCM_RTS))
> +       if (mctrl & TIOCM_RTS)
>                 mcr |= 2;
> -       if (!(mctrl & TIOCM_DTR))
> +       if (mctrl & TIOCM_DTR)
>                 mcr |= 1;
>  
>         __raw_writel(mcr, base + EP93XX_UART_MCR_OFFSET);

would you mind to send that patch to the mainline kernel? Thanks.

-- ynezz


------------------------------------

Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/ts-7000/

<*> Your email settings:
    Individual Email | Traditional

<*> To change settings online go to:
    http://groups.yahoo.com/group/ts-7000/join
    (Yahoo! ID required)

<*> To change settings via email:
     
    

<*> To unsubscribe from this group, send an email to:
    

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/