Hi Matt,
try look at it:
http://lists.arm.linux.org.uk/lurker/thread/20081111.161139.99879953.en.html
I've got other two comments about your patch:
1) about the spi interface in ts72xx.c: in cs_command you use F gpio 2
as gpio port. I read the ts7200 schematic and I found that the chip
select signal for the temp. chip is dio_16. Dio_16 is connected to the
F gpio port 1 not 2, is there some mistake in the schematic?
2) in the spi driver you use 4 as num_chipselect, why? Could you
explain to me?
However I'm working on a new spi driver, I'll post it asap.
Thanks.
Marco
--- In Matthieu Crapet <> wrote:
>
> Hi Marco,
>
> I looked to the discontigmem replacement stuff today.
> I tried to move from ARCH_DISCONTIGMEM_ENABLE to ARCH_SPARSEMEM_ENABLE.
> Let's leave apart the special "2 chips select" case.
>
> It didn't work at all (freeze after the message: Uncompressing
> Linux...............................................................
> done, booting the kernel.)
>
> Tried both:
> #define NODE_MEM_SIZE_BITS 23 // 8mb
> #define NODE_MEM_SIZE_BITS 24 // 16mb
>
> Started to debug kernel with "printascii" and "printhex8" without
result.
>
> Then I wanted to try your new ARCH_HAS_FLATMEM_HOLES way.
> I was not able to find any information about it. Where did you find
this ?
> Are you actually using it ?
>
> Thanks for your help.
> Matthieu
>
>
> greywolf9923 wrote:
> >
> > Hi Matt,
> >
> > two comments:
> >
> > 1) discontigmem is deprecated. Now according to Russel King the new
> > approach is sparsemem. However now the kernel has a new define called
> > ARCH_HAS_FLATMEM_ HOLES, it should be sufficient, so I think the
> > discontigmem stuff in your patch is not needed. You can check my
> > discussion on the arm mailing list.
> >
> > 2) About the led I think it should be sufficient to use the general
> > gpio led support and to do a declaration in the ts72xx.c of them, like
> > this:
> >
> > static const struct gpio_led ts72xx_leds[ ] = {
> > { .name = "green", .gpio = EP93XX_GPIO_ LINE_GRLED, .active_low = 1,
> > .default_trigger = "heartbeat",
> > },
> > { .name = "red", .gpio = EP93XX_GPIO_ LINE_RDLED, .active_low = 1, },
> > };
> >
> > static const struct gpio_led_platform_ data ts72xx_led_data = {
> > .num_leds = ARRAY_SIZE(ts72xx_ leds),
> > .leds = (void *) ts72xx_leds,
> > };
> >
> > static struct platform_device ngw_gpio_leds = {
> > .name = "leds-gpio",
> > .id = -1,
> > .dev = {
> > .platform_data = (void *) &ts72xx_led_ data,
> > }
> > };
> >
> > Regards,
> >
> > Marco
> >
> > --- In .com <ts-7000%40yahoogroups.com>,
> > Matthieu Crapet <mcrapet@ > wrote:
> > >
> > > Greetings,
> > >
> > > Here is a kernel 2.6.27.4 patch (against mainline Linux kernel) for
> > TS-72xx.
> > >
> > > Moved everything from my previous patch for 2.6.24.4 to this
version.
> > > I wanted the new generic GPIO layer.
> > >
> > > The file "linux-2.6.27. 4-ts7200_ matt-1.tar. gz" has been
posted in
> > the
> > > yahoo group file area:
> > > http://tech. groups.yahoo. com/group/ ts-7000/files
> > <http://tech.groups.yahoo.com/group/ts-7000/files>
> > >
> > > Either cumulative or single patches are available.
> > >
> > > Comments are welcome.
> > >
> > > Best regards,
> > > Matthieu
> >
>
------------------------------------
Yahoo! Groups Links
<*> To visit your group on the web, go to:
http://groups.yahoo.com/group/ts-7000/
<*> Your email settings:
Individual Email | Traditional
<*> To change settings online go to:
http://groups.yahoo.com/group/ts-7000/join
(Yahoo! ID required)
<*> To change settings via email:
<*> To unsubscribe from this group, send an email to:
<*> Your use of Yahoo! Groups is subject to:
http://docs.yahoo.com/info/terms/
|