pwc
[Top] [All Lists]

Re: [pwc] Auto Shutter and v4l2

To: Philips Webcam Linux Driver <>
Subject: Re: [pwc] Auto Shutter and v4l2
From: Hugo Costelha <>
Date: Wed, 9 Nov 2005 16:55:18 +0000
I am implementing the camera access and still haven't got the code completed 
enough to see the images retrieved by the camera, so I cannot perform a 
complete test to your patch. If there is anyone else that can test it, please 
do so.

In the mean time, if I am able to test your patch, I will send you the 
results.

Hugo Costelha

On Wednesday 09 November 2005 16:19, Luc Saillard wrote:
> On Wed, Nov 09, 2005 at 04:11:07PM +0000, Ivor Hewitt wrote:
> > Luc Saillard wrote:
> > >On Fri, Nov 04, 2005 at 10:49:27AM +0000, Hugo Filipe Costelha De Castro
> > >wrote:
> >
> > I guess the question is what do other drivers use for auto-shutter? 0
> > seems like a sensible choice, after all why else would you be setting a
> > zero exposure.
>
> Here the patch, can you test it before commit ?
>
> # svn diff pwc-v4l.c
> Index: pwc-v4l.c
> ===================================================================
> --- pwc-v4l.c   (revision 89)
> +++ pwc-v4l.c   (working copy)
> @@ -105,7 +105,7 @@
>             .id      = V4L2_CID_EXPOSURE,
>             .type    = V4L2_CTRL_TYPE_INTEGER,
>             .name    = "Shutter Speed (Exposure)",
> -           .minimum = 1,
> +           .minimum = 0,
>             .maximum = 256,
>             .step    = 1,
>             .default_value = 200,
> @@ -699,7 +699,7 @@
>                                         return 0;
>                                 case V4L2_CID_EXPOSURE:
>                                         c->value <<= 8;
> -                                       ret = pwc_set_shutter_speed(pdev,
> 0, c->value); +                                       ret =
> pwc_set_shutter_speed(pdev, c->value?0:1, c->value); if (ret<0)
>                                                 return -EINVAL;
>                                         return 0;
>
>
> _______________________________________________
> pwc mailing list
> 
> http://lists.saillard.org/mailman/listinfo/pwc
_______________________________________________
pwc mailing list

http://lists.saillard.org/mailman/listinfo/pwc

<Prev in Thread] Current Thread [Next in Thread>
Admin

Disclaimer: Neither Andrew Taylor nor the University of NSW School of Computer and Engineering take any responsibility for the contents of this archive. It is purely a compilation of material sent by many people to the birding-aus mailing list. It has not been checked for accuracy nor its content verified in any way. If you wish to get material removed from the archive or have other queries about the archive e-mail Andrew Taylor at this address: andrewt@cse.unsw.EDU.AU