Re: [pwc] Auto Shutter and v4l2

[Luc Saillard <>]

On Wed, Nov 09, 2005 at 04:11:07PM +0000, Ivor Hewitt wrote:
> Luc Saillard wrote:
> >On Fri, Nov 04, 2005 at 10:49:27AM +0000, Hugo Filipe Costelha De Castro 
> >wrote:
>
> I guess the question is what do other drivers use for auto-shutter? 0 
> seems like a sensible choice, after all why else would you be setting a 
> zero exposure.
>
Here the patch, can you test it before commit ?

# svn diff pwc-v4l.c 
Index: pwc-v4l.c
===================================================================
--- pwc-v4l.c   (revision 89)
+++ pwc-v4l.c   (working copy)
@@ -105,7 +105,7 @@
            .id      = V4L2_CID_EXPOSURE,
            .type    = V4L2_CTRL_TYPE_INTEGER,
            .name    = "Shutter Speed (Exposure)",
-           .minimum = 1,
+           .minimum = 0,
            .maximum = 256,
            .step    = 1,
            .default_value = 200,
@@ -699,7 +699,7 @@
                                        return 0;
                                case V4L2_CID_EXPOSURE:
                                        c->value <<= 8;
-                                       ret = pwc_set_shutter_speed(pdev, 0, 
c->value);
+                                       ret = pwc_set_shutter_speed(pdev, 
c->value?0:1, c->value);
                                        if (ret<0)
                                                return -EINVAL;
                                        return 0;


_______________________________________________
pwc mailing list

http://lists.saillard.org/mailman/listinfo/pwc