[pwc] [PATH] libpwc brg vs rgb problem in wc_yuv420p_to_rgb24_same_size()

[Gert Vervoort <>]

Hi,

It seems my first messages did not get through to the list, because I had not
yet confirmed my subscribtion information.


While trying to decompress a frame captured from my Philips PCVC675K 
webcam, I noticed that the colors where swapped.


In the routine pwc_yuv420p_to_rgb24_same_size(), there BGR_OUT() instead 
of RGB_OUT() macros are used:

--- libpwc-20060524/convert.c    2006-05-24 21:22:06.000000000 +0200
+++ libpwc/convert.c    2007-09-15 19:07:57.000000000 +0200
@@ -376,10 +376,10 @@
      {
    int cb, cr, r_add, g_add, b_add;
    LOAD_UV_FOR_RGB(pu, pv);
-    BGR_OUT(yline1, dline1);
-    BGR_OUT(yline1, dline1);
-    BGR_OUT(yline2, dline2);
-    BGR_OUT(yline2, dline2);
+    RGB_OUT(yline1, dline1, r_add, g_add, b_add);
+    RGB_OUT(yline1, dline1, r_add, g_add, b_add);
+    RGB_OUT(yline2, dline2, r_add, g_add, b_add);
+    RGB_OUT(yline2, dline2, r_add, g_add, b_add);
      }

     d  += d_offset_to_next_line * 2;

Due to an error in my capture program I was actually trying to decode an yuv 
(V4L2_PIX_FMT_YUV420) frame instead of a raw (V4L2_PIX_FMT_PWC2).
.

 Gert




_______________________________________________
pwc mailing list

http://lists.saillard.org/mailman/listinfo/pwc